Skip to content

CNTRLPLANE-3002: allow conversion webhooks on azure#76413

Open
clebs wants to merge 1 commit intoopenshift:mainfrom
clebs:azure-conversion-webhooks
Open

CNTRLPLANE-3002: allow conversion webhooks on azure#76413
clebs wants to merge 1 commit intoopenshift:mainfrom
clebs:azure-conversion-webhooks

Conversation

@clebs
Copy link
Member

@clebs clebs commented Mar 17, 2026

For the upgrade to CAPI 1.11 conversion between v1beta1 and v1beta2 is needed.

@clebs
fix(conversion): allow conversion webhooks on azure
d7f8447 
For the upgrade to CAPI 1.11 conversion between v1beta1 and v1beta2 is
needed.

Signed-off-by: Borja Clemente <bclement@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2026
@clebs
Copy link
Member Author

clebs commented Mar 17, 2026

/pj-rehearse ?

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2026

@clebs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clebs
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2026

[REHEARSALNOTIFIER]
@clebs: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cloud-network-config-controller-main-hypershift-e2e-aks openshift/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-cloud-network-config-controller-release-5.0-hypershift-e2e-aks openshift/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-cloud-network-config-controller-release-4.23-hypershift-e2e-aks openshift/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-cloud-network-config-controller-release-4.22-hypershift-e2e-aks openshift/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-cloud-network-config-controller-release-4.21-hypershift-e2e-aks openshift/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-cloud-network-config-controller-release-4.20-hypershift-e2e-aks openshift/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-cloud-network-config-controller-release-4.19-hypershift-e2e-aks openshift/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-master-hypershift-e2e-aks openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-5.0-hypershift-e2e-aks openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.23-hypershift-e2e-aks openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.22-hypershift-e2e-aks openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.21-hypershift-e2e-aks openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.20-hypershift-e2e-aks openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.19-hypershift-e2e-aks openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-master-e2e-aws-hypershift-ovn-kubevirt openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-5.0-e2e-aws-hypershift-ovn-kubevirt openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.23-e2e-aws-hypershift-ovn-kubevirt openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.22-e2e-aws-hypershift-ovn-kubevirt openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.21-e2e-aws-hypershift-ovn-kubevirt openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.20-e2e-aws-hypershift-ovn-kubevirt openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.19-e2e-aws-hypershift-ovn-kubevirt openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.18-e2e-aws-hypershift-ovn-kubevirt openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-aws-hypershift-ovn-kubevirt openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.16-e2e-aws-hypershift-ovn-kubevirt openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.15-e2e-aws-hypershift-ovn-kubevirt openshift/cluster-network-operator presubmit Registry content changed

A total of 876 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2026

@clebs: job(s): ? either don't exist or were not found to be affected, and cannot be rehearsed

@clebs
Copy link
Member Author

clebs commented Mar 17, 2026

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2026

@clebs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bryan-cox
Copy link
Member

bryan-cox commented Mar 17, 2026

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2026

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bryan-cox
Copy link
Member

bryan-cox commented Mar 17, 2026

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-azure-self-managed

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2026

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@clebs clebs marked this pull request as ready for review March 18, 2026 11:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2026
@openshift-ci openshift-ci bot requested review from csrwng and sjenning March 18, 2026 11:54
@clebs clebs changed the title JIRA-PENDING: allow conversion webhooks on azure CNTRLPLANE-3002: allow conversion webhooks on azure Mar 18, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 18, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 18, 2026 •
edited by openshift-ci bot
Loading

@clebs: This pull request references CNTRLPLANE-3002 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

For the upgrade to CAPI 1.11 conversion between v1beta1 and v1beta2 is needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2026

@clebs: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/hypershift/main/e2e-aks d7f8447 link unknown /pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@sjenning sjenning Awaiting requested review from sjenning

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clebs @openshift-ci-robot @bryan-cox